Use a structure for XYZE-oriented data #15204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
2 times, most recently
from
b8a54b1
to
9dd9a2e
Compare
|
Did you check the impact on 8-bitters, with their slow (16 bit) address arithmetic? |
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
3 times, most recently
from
1b2af7a
to
dd789fa
Compare
|
These changes will only affect compile-time behavior. It's not meant to produce any change in the underlying binary output, but just a change in the semantics. The main purpose is to allow |
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
6 times, most recently
from
5bdedd4
to
efec686
Compare
MagoKimbra
reviewed
Sep 10, 2019
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
14 times, most recently
from
e30a626
to
db477df
Compare
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
15 times, most recently
from
db5a1f5
to
54d8ce3
Compare
thinkyhead
force-pushed
the
bf2_position_struct_pr
branch
from
54d8ce3
to
48f50c5
Compare
mmcx
reviewed
Oct 6, 2019
edwilliams16
referenced
this pull request
Oct 8, 2019
rolkun
pushed a commit
to rolkun/Marlin
that referenced
this pull request
Oct 25, 2019
markus-seidl
pushed a commit
to markus-seidl/Marlin
that referenced
this pull request
Oct 31, 2019
robbycandra
added a commit
to robbycandra/Marlin
that referenced
this pull request
Nov 16, 2019
# Conflicts: # Marlin/src/feature/power_loss_recovery.cpp # Marlin/src/gcode/bedlevel/abl/G29.cpp # Marlin/src/gcode/calibrate/G425.cpp # Marlin/src/gcode/feature/pause/M701_M702.cpp # Marlin/src/lcd/menu/menu_advanced.cpp # Marlin/src/libs/nozzle.cpp # Marlin/src/module/configuration_store.cpp # Marlin/src/module/delta.cpp # Marlin/src/module/motion.cpp # Marlin/src/module/motion.h # Marlin/src/module/probe.cpp # Marlin/src/module/probe.h # Marlin/src/module/scara.cpp
robbycandra
added a commit
to robbycandra/Marlin
that referenced
this pull request
Nov 16, 2019
thinkyhead
added a commit
to drunken-octopus/drunken-octopus-marlin
that referenced
this pull request
Apr 1, 2021
Regression from MarlinFirmware#15204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use structures with anonymous unions to store axis-oriented arrays for easier access to fields and easier copying of positional data.
Old code:
float raw[XYZE] = { current_position[X_AXIS], current_position[Y_AXIS], current_position[Z_AXIS], current_position[E_AXIS] };New code:
xyze_pos_t raw = current_position;