-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Wrong MPC settings can cause thermal runaway #27253
Comments
@tombrazier Can you take a look at this? |
Protecting against dangerous bad config is a very good idea. I am concerned that the values all ended up as zero in the first place, though. Did this happen with I think the following is needed:
|
0's are a result of bug #27236 now fixed |
No, there is an issue in the loading of the settings, I reported it here: #27236.
That makes perfect sense to me. There is a report that somebody got negative values, that seems quite odd: #27181 I see you are onto that one already. Also make sure no divide by zero can occure. |
was an issue. That's now patched 🙂 |
Right, tested it, works fine now, great job🙂 |
guess it can be closed then. |
Fixed in #27274 |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
I already reported this in #27236, but no response there and I think this issue needs attention.
Because of #27236 all my MPC settings were set to 0, which causes a thermal runaway of the hotend, the heater keeps heating 100% while the target temp is not changed (still set to 0). I use a ceramic heater which did not survive this, even though I have thermal protection enabled.
Bug Timeline
Introduction of MPC (I guess)
Expected behavior
MPC doesn't allow bad values, to prevent a thermal runaway.
Actual behavior
Hotend thermal runaway (broken ceramic heater)
Steps to Reproduce
RECOVERY: Run M502, M500 and restart the printer
Version of Marlin Firmware
Latest bugfix July 2024
Printer model
Custom
Electronics
MKS Monster8 V1.0
LCD/Controller
BTT TFT35 V3.0
Other add-ons
BTT EBB42 V1.2
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
I suggest to set some limits to the MPC parameters where needed.
I guess all values should be positive, and MPC_HEATER_POWER should have a minimum value (10?).
Setting some values to 0 might cause a divide by 0 issue, causing unpredictable results.
Configuration_adv.zip
The text was updated successfully, but these errors were encountered: