Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky #7145

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Fix flaky #7145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a2dd1c
fixed flaky test
AinaMerch Jun 28, 2024
0426272
Testing attempt
AinaMerch Jul 11, 2024
a00161b
Removed bash script
AinaMerch Jul 12, 2024
a25d3c3
Updated Changelog
AinaMerch Jul 12, 2024
e7fe86f
Merge branch 'master' into fix-flaky
AinaMerch Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
- Upgrade pdfjs-dist to v4.3.136 (#7113)
- Fixed formatting of documentation repository on the PR template (#7120)
- Switch from rails-sassc to cssbundling-rails for CSS asset management (#7121)
- Fixed flaky test #creates groups for individual students in groups_controller_spec (#7145)
- Switch from SyntaxHighlighter to Prism for syntax highlighting (#7122)

## [v2.4.12]
Expand Down
8 changes: 7 additions & 1 deletion spec/controllers/groups_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,13 @@
params: { course_id: course.id, assignment_id: assignment.id },
format: 'js'

assert_enqueued_with(job: CreateGroupsJob, args: [assignment, data])
expected_args = ->(job_args) do
assignment_arg, data_arg = job_args
expect(assignment_arg).to eq(assignment)
expect(data_arg).to match_array(data)
end

assert_enqueued_with(job: CreateGroupsJob, args: expected_args)
expect(flash[:error]).to be_blank
end

Expand Down