Allow instructors to configure an end date until which students can run automated tests #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end-date-for-student-tests
… end-date-for-student-tests
… end-date-for-student-tests
Pull Request Test Coverage Report for Build 8498291012Details
💛 - Coveralls |
| @@ -31,6 +31,7 @@ en: | |||
| short_identifier: Short Identifier | |||
| start_time: Start time | |||
| student_form_groups: Students may form their own groups | |||
| token_end_date: Tokens will be unavailable on | |||
There was a problem hiding this comment.
reword to "Tokens available until"
config/locales/policies/en.yml
Outdated
| @@ -18,6 +18,7 @@ en: | |||
| view_ta_subtabs?: You are not authorized to perform this action. | |||
| assignment: | |||
| autogenerate_group_name?: This assignment does automatically generate group names. | |||
| before_token_end_date?: The token end date for this assignment has passed. | |||
There was a problem hiding this comment.
Reword to "Tokens are no longer available for this assignment."
db/structure.sql
Outdated
| -- Name: index_assignment_properties_on_token_end_date; Type: INDEX; Schema: public; Owner: - | ||
| -- | ||
|
|
||
| CREATE INDEX index_assignment_properties_on_token_end_date ON public.assignment_properties USING btree (token_end_date); |
There was a problem hiding this comment.
This should no longer exist, since you removed it from the migration. This indicates that this file is out of sync with your migration. The easiest way to fix this is to revert all changes in this specific file, then re-run the migration.
lib/tasks/autotest.rake
Outdated
| @@ -80,6 +80,7 @@ class AutotestSetup | |||
| repository_folder: @assg_short_id, | |||
| enable_test: true, | |||
| token_start_date: Time.current, | |||
| token_end_date: Time.current, | |||
There was a problem hiding this comment.
This is for seeding, but it should also be okay to set this to nil so that the field is blank (this is the default behaviour)
app/policies/student_policy.rb
Outdated
| check?(:tokens_available?, grouping) | ||
| end | ||
| unless grouping.nil? || assignment.nil? | ||
| if !assignment.token_end_date.nil? |
There was a problem hiding this comment.
Use .present? instead of ! ... .nil?
… end-date-for-student-tests
… end-date-for-student-tests
…-8/Markus into end-date-for-student-tests
david-yz-liu
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #6822. Currently, MarkUs allows instructors to enable a "start date" at which students can begin running "student-run tests". Tests can be run up until the assignment due date. This pull request augments this functionality to allow the instructor to configure an end date until which students can run tests. If the end date is left blank, the existing functionality (up until assignment due date) will be used instead.
Your Changes
Description:
token_end_dateattribute toassignment_properties.token_end_date.assignment_policyandstudent_policythat check for whether the student can run automated testing based on the value fortoken_end_date.Type of change (select all that apply):
Testing
token_end_datein the web UI.Questions and Comments (if applicable)
Just checked with my group members as well and wanted to bring to your attention that the flaky test file
spec/system/main/login_spec.rbis not passing, but I checked to make sure that it's not because of my changes.Checklist