Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick project writeup #2545

Merged
merged 5 commits into from
May 2, 2024
Merged

Quick project writeup #2545

merged 5 commits into from
May 2, 2024

Conversation

kaixin-hc
Copy link
Contributor

@kaixin-hc kaixin-hc commented May 1, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Fix #813

Overview of changes:

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Add info about maintaining a project roadmap to devdocs


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit should not be here 😆

Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should have fullstops for all the points what do you think 🤣 .

It may just be me but I think I prefer full stops. (but it is okay if u dun change it)

docs/devGuide/projectManagement.md Outdated Show resolved Hide resolved
docs/devGuide/projectManagement.md Outdated Show resolved Hide resolved
docs/devGuide/projectManagement.md Outdated Show resolved Hide resolved
docs/devGuide/projectManagement.md Outdated Show resolved Hide resolved
kaixin-hc and others added 3 commits May 1, 2024 21:46
Co-authored-by: Elton Goh Jun Hao <75515229+EltonGohJH@users.noreply.github.com>
Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaixin-hc kaixin-hc merged commit f18d2f1 into MarkBind:master May 2, 2024
8 checks passed
Copy link

github-actions bot commented May 2, 2024

@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.

@kaixin-hc kaixin-hc added the r.Patch Version resolver: increment by 0.0.1 label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a high-level product roadmap for MarkBind
2 participants