Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert expand collapse all buttons #2303

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

itsyme
Copy link
Contributor

@itsyme itsyme commented Jun 3, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain: Revert previous feature

Overview of changes:
Addresses the reverting in #2299.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Revert expand collapse all buttons


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@itsyme itsyme requested a review from tlylt June 3, 2023 03:04
@itsyme itsyme removed the request for review from tlylt June 3, 2023 03:46
@itsyme itsyme requested a review from tlylt June 3, 2023 04:24
@jovyntls
Copy link
Contributor

jovyntls commented Jun 6, 2023

Hey @itsyme , just to check, this is purely a revert of the CollapseExpandAll PR (#2206) with no other changes?

@itsyme
Copy link
Contributor Author

itsyme commented Jun 7, 2023

Hey @itsyme , just to check, this is purely a revert of the CollapseExpandAll PR (#2206) with no other changes?

yup!

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @itsyme

@tlylt tlylt added this to the v5.0.0 milestone Jun 8, 2023
Copy link
Contributor

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @itsyme, LGTM!

@@ -18,7 +18,7 @@

<div id="overview" class="lead">

This page lists some other components that may be useful in creating education websites.
This page lists some other components that may be useful in creating education websites. For now, there are only question and quiz components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that we removed this sentence in #2206 so it is being added back, but I am not sure if this sentence is really necessary 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants