Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace set-output with $GITHUB_OUTPUT in documentation #2259

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

yucheng11122017
Copy link
Contributor

@yucheng11122017 yucheng11122017 commented Apr 2, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

As set-output and save-state is set to be deprecated, this needs to be replaced. No instances of save-state.

Similar PR opened for markbind-action here

Overview of changes:
Replace set-output with $GITHUB_OUTPUT

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Replace set-output with $GITHUB_OUTPUT in documentation


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlylt
Copy link
Contributor

tlylt commented Apr 6, 2023

Thanks @yucheng11122017, can help out with reposense/RepoSense#1967 if you are keen and still available.

@tlylt tlylt added this to the v4.1.1 milestone Apr 10, 2023
@tlylt tlylt changed the title Replace set-output with github_output Replace set-output with $GITHUB_OUTPUT in documentation Apr 10, 2023
@tlylt tlylt merged commit d6bf5fb into MarkBind:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants