Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non-default plugins to TypeScript #2230

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

jovyntls
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrates the 5 non-default plugins to TS

Anything you'd like to highlight/discuss:
N/A

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)
(rebase commit)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jovyntls jovyntls force-pushed the ts-migrate-nondefault-plugins branch 2 times, most recently from 030c1de to 86a4795 Compare March 21, 2023 02:18
@jovyntls jovyntls changed the title Migrate non-default plugins to TS Migrate non-default plugins to TypeScript Mar 21, 2023
@jovyntls jovyntls force-pushed the ts-migrate-nondefault-plugins branch from 86a4795 to 914e9b5 Compare March 21, 2023 09:36
Copy link
Contributor

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovyntls jovyntls added this to the v4.1.1 milestone Mar 24, 2023
@jovyntls jovyntls force-pushed the ts-migrate-nondefault-plugins branch 2 times, most recently from 12e18d4 to 8067329 Compare March 24, 2023 14:53
Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jovyntls can fix the conflicts and merge when you are ready

@jovyntls jovyntls force-pushed the ts-migrate-nondefault-plugins branch from 8067329 to 89b36d0 Compare March 25, 2023 02:09
@jovyntls jovyntls merged commit bb55a69 into MarkBind:master Mar 25, 2023
@jovyntls jovyntls deleted the ts-migrate-nondefault-plugins branch March 25, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants