Add missing slots-info modal to pages in UG #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xMissingModalInUG
tlylt
approved these changes
Mar 17, 2023
tlylt
changed the title
ong6
pushed a commit
to ong6/markbind
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Resolves #2220
Overview of changes:
Added modal to reader facing features and full syntax references.
Anything you'd like to highlight/discuss:
An alternative to having users to keep including the modal is to include the modal in the import for the trigger. But this would mean that
advanced.mdwould need quite a bit of duplicated code. This is because includes doesn't work in the import as the src file not be resolved properly. Hence, there would need for the code to be duplicated for the import.Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add slots-info modal to readerFacingFeature and fullSyntaxReference
Checklist: ☑️