-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panel transition abruptly snapping to the end #2200
Merged
raysonkoh
merged 11 commits into
MarkBind:master
from
yucheng11122017:panelTransitionSnap
Mar 19, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
52eecd1
Add bottom margin of collapse button to max height of panel
yucheng11122017 09c7b4d
Add comments explaining why is collapse's button marginBottom is added
yucheng11122017 380092d
Add edge cases for getMaxHeight
yucheng11122017 7c86db2
[WIP] Add test cases for transition
yucheng11122017 d84fe72
Update test output
yucheng11122017 c1f7ef9
Merge branch 'master' of https://github.com/MarkBind/markbind into pa…
yucheng11122017 b35a967
Update maxHeight to include bottom margin of bottom switch
yucheng11122017 bd6858b
Change name of test case
yucheng11122017 1f9abeb
Remove obsolete snapshot
yucheng11122017 0eb1f09
Merge branch 'master' of https://github.com/MarkBind/markbind into pa…
yucheng11122017 a4a905c
Merge branch 'master' of https://github.com/MarkBind/markbind into pa…
yucheng11122017 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would creating a
<div>
wrapper with bottom padding instead work?