-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate default plugins to TypeScript #2199
Migrate default plugins to TypeScript #2199
Conversation
1ad6133
to
e33351c
Compare
f9fd09e
to
cbd092f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @jovyntls! LGTM!
ba9f077
to
43071db
Compare
a828ab2
to
4bfa855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jovyntls, I think looks great!
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrates 4 default plugins to TS:
markbind-plugin-anchors.js
markbind-plugin-plantuml.js
markbind-plugin-shorthandSyntax.js
markbind-plugin-tree.js
Anything you'd like to highlight/discuss:
N/A
Testing instructions:
N/A
Proposed commit message: (wrap lines at 72 characters)
(rebase commit)
Checklist: ☑️