Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iconColor in box when light/seamless is used #2178

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

yucheng11122017
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Fixes #2174

Overview of changes:
Add !important to custom icon color to override default colors.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Support iconColor in box when light/seamless is used


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@yucheng11122017 yucheng11122017 requested a review from a team February 20, 2023 05:42
Copy link
Contributor

@jovyntls jovyntls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comprehensive tests!

@jovyntls jovyntls added this to the v4.1.1 milestone Feb 21, 2023
@jovyntls jovyntls changed the title Icon color override Support iconColor in box when light/seamless is used Feb 23, 2023
@jovyntls jovyntls merged commit 080bcd0 into MarkBind:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iconColor not working for box when light or seamless is enabled
2 participants