-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize code fixes and analyzers #4100
Conversation
I would say this is draft to gather feedback on some key decisions which I have to do.
|
If it's a draft please make it a real draft. Otherwise rocky may just merge it ;) |
My first scan through the code changes is quite positive, I like what you've done so far. Can you provide more detail about the three decision points, and what you recommend? |
@StefanOssendorf unfortunately I press buttons first and think second. So I miss that opportunity 😄 @rockfordlhotka one by one.
|
@rockfordlhotka can you take a look? |
I'm out of town this week, and will look when I get back. |
Closes #1352