Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotter settings: what does "reset" even do? #723

Closed
i-make-robots opened this issue Oct 23, 2023 · 3 comments
Closed

plotter settings: what does "reset" even do? #723

i-make-robots opened this issue Oct 23, 2023 · 3 comments
Labels
bug

Comments

@i-make-robots
Copy link
Contributor

Steps to make the bug happen

  1. Go to settings > plotter settings
  2. Click on reset.
  3. change something.
  4. Click on reset.

What was supposed to happen
I don't know. it doesn't appear to do anything.

Platform (please complete the following information):

  • Version: 7.49.2

Log file
@i-make-robots
Copy link
Contributor Author

i-make-robots commented Oct 23, 2023 •
edited
Loading

image

If I change some value and DO NOT hit save, then press reset it will undo the change. If I hit save then reset will have no effect.

It will also reset all four tabs in the sunken area of the panel.

@i-make-robots
Copy link
Contributor Author

in b9724bb i hide the save/reset buttons on ancestors.

i-make-robots added a commit that referenced this issue Nov 21, 2023
@i-make-robots
Work on #723 (#731)
26be9fa 
* make SaveGCode work like all other TurtleSaver classes.
* PlotterSettings no longer write on every put or get
* fix for #729
* don't display save/reset if this setting has no ancestors.
* tweak pen up/down times
* machine width and height read only in progenitors.
* fix font in visual inspection
* 🚚 PaperSettings > PaperSettingsPanel
* change button to fire actions, update firmware better.
* use dedicated listener/event, fix paper shift in generators
* remember shift x + shift y
* make random seed visible to users.
* generators now properly center and size-to-fit
* fixed PaperSettingsPanelTest at last!
* added bitmap preview to file open dialog
* removed duplicate "learn" link from maze circle generator
* added "open log folder" button to help menu
@i-make-robots
Copy link
Contributor Author

reset now returns settings to progenitor values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@i-make-robots