Expose the webhook service loop sleep time as an env var #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the sleep time for the webhook service loop as
HLL_WH_LOOP_SLEEP_TIMEso that users can choose a value easily without rebuilding images if they would like to adjust it.I tested this both with and without a value set to make sure that it works even if people don't update their
.envfile.I set the default to
0.006seconds which should cut down on CPU usage but still be responsive.CPU usage seems to be quite low even with an idle loop (which is simply sleeping/checking redis for queue keys), although
docker statsappears to show incorrect CPU stats compared tobtopinside the container.