Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade packages #333

Merged
merged 2 commits into from
May 8, 2021
Merged

Upgrade packages #333

merged 2 commits into from
May 8, 2021

Conversation

SergerGood
Copy link
Contributor

No description provided.

@chaowlert
Copy link
Collaborator

I'm ok with updating benchmark or testing projects. But I'm not sure we should bump version for production related.

@SergerGood
Copy link
Contributor Author

I rolled back the production versions.

But why not?
For example Mapster.Async 7.2.0 refers to Mapster 7.1.5.
In general, updating package versions is a practice that helps to work with more stable versions.

@chaowlert
Copy link
Collaborator

Totally agree to update version. I also just bump Mapster to 7.1.5 (latest on that time) for Async module when it released.

However:

  1. I have no plan to release the other packages, so let's keep versioning the same as package for now.
  2. Bumping version might require testing. It is more effective to test together with new features (or bug fixing). So for now, we have no reason to touch it.

@chaowlert chaowlert merged commit f5f5426 into MapsterMapper:master May 8, 2021
@SergerGood SergerGood deleted the update-packages branch May 8, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergerGood @chaowlert