-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test refactor, making them faster #574
Conversation
It's fantastic how fast they run. I ran them 4 times, but had a failure in one run, that disappeared in subsequent runs. Have you noticed this, and if so is it a setting that could be adjusted? |
Do you remember the test? This is probably an issue related to actions being made too quickly. Since mapml-viewer is visual with animations, parts of the code need timeouts to allow the animations and loading to complete. You can simply increase the overall |
No I didn't take note. I will play around to see if I encounter it again. |
Try adding timeouts to parts, for example many keyboard actions at one point, see if that fixes it. Those files for me didn't cause issues but it's very hardware dependent (without timeouts). |
yea, adding a larger timeout number seemed to fix it for me |
OK, I couldn't get the tests to fail again on that branch. It could have to do with caching resources, that happens at levels we might not be aware of. So, let's merge and deal with issues as they may come. |
Refactor and parallelism resulted in tests running in under 2 minutes (or less).
This requires the use of
await page.waitForTimeout(200);
when doing many keyboard interactions in a row to prevent missed keys.Closes #518 (indirect, as instead of launching a single browser, it's launching multiple browsers depending on the device)