Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation[:lapse] become relation[:lapses] #265

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

fonsecadeline
Copy link
Contributor

No description provided.

@fonsecadeline fonsecadeline force-pushed the relation_lapses branch 3 times, most recently from 4dc4082 to 7a3a44a Compare August 11, 2021 13:54
wrappers/ortools.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline force-pushed the relation_lapses branch 2 times, most recently from 8be47f4 to 97d6755 Compare August 11, 2021 15:16
models/concerns/validate_data.rb Outdated Show resolved Hide resolved
models/relation.rb Outdated Show resolved Hide resolved
models/concerns/validate_data.rb Outdated Show resolved Hide resolved
api/v01/entities/vrp_input.rb Outdated Show resolved Hide resolved
models/concerns/validate_data.rb Outdated Show resolved Hide resolved
models/concerns/validate_data.rb Outdated Show resolved Hide resolved
models/vrp.rb Outdated Show resolved Hide resolved
models/relation.rb Outdated Show resolved Hide resolved
models/relation.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline force-pushed the relation_lapses branch 2 times, most recently from 4380742 to 1df84fe Compare August 12, 2021 09:51
@fonsecadeline fonsecadeline requested a review from senhalil August 12, 2021 09:55
test/test_helper.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@senhalil senhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except this, perfect 🚀 thanks @fonsecadeline !

@fonsecadeline fonsecadeline force-pushed the relation_lapses branch 2 times, most recently from ccf4e9e to 8a325ab Compare August 12, 2021 14:28
@senhalil
Copy link
Contributor

senhalil commented Aug 12, 2021

@fonsecadeline I just realised we forgot to mention this change in the CHANGELOG.md, can you mention under changed section that lapse became lapses... (I would appreciate if you can do it in a new separate commit so that I don't need to rebase 266)

fonsecadeline and others added 2 commits August 13, 2021 10:11
Co-authored-by: Halil Sen <halil.sen@mapotempo.com>
@fab-girard fab-girard merged commit 1382f09 into Mapotempo:dev Aug 13, 2021
@fonsecadeline fonsecadeline deleted the relation_lapses branch August 13, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants