Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document output #224

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Document output #224

merged 2 commits into from
Aug 13, 2021

Conversation

braktar
Copy link
Contributor

@braktar braktar commented Jun 1, 2021

No description provided.

fonsecadeline
fonsecadeline reviewed Jun 1, 2021
View reviewed changes
api/v01/vrp.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline mentioned this pull request Jun 1, 2021
Merged
@braktar braktar requested a review from fonsecadeline June 1, 2021 15:19
@braktar braktar requested a review from fonsecadeline June 4, 2021 08:06
senhalil
senhalil reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@senhalil senhalil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good 👍 I have some suggestions for us to discuss

api/v01/vrp.rb Outdated Show resolved Hide resolved
api/v01/vrp.rb Outdated Show resolved Hide resolved
@braktar braktar force-pushed the doc-out branch 2 times, most recently from 41058b3 to 410dda8 Compare June 7, 2021 09:53
@braktar braktar requested review from senhalil and fonsecadeline June 7, 2021 09:54
@senhalil
Copy link
Contributor

senhalil commented Jun 8, 2021

Failing test is not related. We can merge it wo re-test.

 FAIL["test_detecting_unfeasible_services_can_not_take_too_long", #<Minitest::Reporters::Suite:0x00005622133b5c50 @name="WrapperTest">, 30.50278225599999]
 test_detecting_unfeasible_services_can_not_take_too_long#WrapperTest (30.50s)
        check_distances function took longer than expected.
        Expected 3.0710660050000005 to be <= 3.0.

@fab-girard fab-girard merged commit ef3e289 into Mapotempo:dev Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fonsecadeline fonsecadeline fonsecadeline approved these changes

@senhalil senhalil senhalil approved these changes

@fab-girard fab-girard Awaiting requested review from fab-girard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braktar @senhalil @fonsecadeline @fab-girard