CSV output columns consistent with provided language [former PR32] #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsecadeline
force-pushed
the
language_in_csv
branch
from
817282d to
80a69b1
Compare
braktar
approved these changes
Apr 26, 2021
senhalil
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
@fonsecadeline I feel like the renaming done in PR #174 might create a problem for this PR, am I right? If there is a risk, which one needs to be merged first, can you add a task so that we don't merge them in wrong order.
|
@senhalil @braktar I added one commit because I realized that use_deprecated_csv_headers was not working as expected from front page. In fact we used to modify I18n value when calling vrp.create. But when calling GET with a different language it did not "remember" we had asked for use_deprecated_csv_headers.
|
fonsecadeline
commented
Apr 29, 2021
fonsecadeline
force-pushed
the
language_in_csv
branch
from
6ca46a3 to
c29cda1
Compare
|
I had to force push after rebasing with dev and fixing some errors. Non reviewed changes are in 77fa93d |
|
fonsecadeline
force-pushed
the
language_in_csv
branch
2 times, most recently
from
96ceb8a to
5b1e4e8
Compare
fonsecadeline
force-pushed
the
language_in_csv
branch
from
5b1e4e8 to
dc3c88e
Compare
senhalil
approved these changes
Jun 10, 2021
braktar
reviewed
Jun 10, 2021
fonsecadeline
force-pushed
the
language_in_csv
branch
from
dc3c88e to
0044c6f
Compare
braktar
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.