Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to parent language for missing translations and update Spanish locale #423

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

xoascf
Copy link
Contributor

@xoascf xoascf commented Nov 30, 2024

Implement a fallback mechanism to load the parent language translation if the specific locale translation is not found. Update the Spanish translation file to use the parent language ID code.

On my computer, the application tries to load the "es-PE" translation, if the full locale translation file is not found, the application loads the "es" translation, if that file is still not found, the application loads the "en-US" translation.
Also, rename the file to use the parent language ID code.
@xoascf
Copy link
Contributor Author

xoascf commented Dec 1, 2024

@Maplespe, the es-ES translation was not included in the latest release:
notinrel

The es-MX translation is also outdated, it still works, but with this new version of the translation it shouldn't be needed, as it should be understood the same way, trying to be as neutral as possible instead of using regional wording.

Also, I had to revert commit e19ea5f locally to get DWMBlurGlassExt to compile, bad merge?

@Maplespe Maplespe merged commit 44b5ded into Maplespe:master Dec 2, 2024
@xoascf xoascf deleted the load-parent-locale branch December 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants