Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify ledger synchronization protocol #86

Merged
merged 13 commits into from
Jun 9, 2022
Merged

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 3, 2022

Simplifies the Ledger synchronization protocol by performing some checkpoint optimizations before and during the execution of regular calls to sync.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes self-assigned this Jun 3, 2022
@bhgomes bhgomes added this to the Version 1 milestone Jun 3, 2022
@bhgomes bhgomes marked this pull request as ready for review June 9, 2022 02:32
stechu
stechu previously approved these changes Jun 9, 2022
@stechu
Copy link
Collaborator

stechu commented Jun 9, 2022

LGTM. see the minor change request.

@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog release:minor Release: generate a `minor` release tag norelease and removed enhancement release:minor Release: generate a `minor` release tag labels Jun 9, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested a review from stechu June 9, 2022 14:44
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes modified the milestones: v1.0.0, v0.5.0 Jun 9, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@stechu stechu merged commit e2cc2f1 into main Jun 9, 2022
@stechu stechu deleted the feat/simplify-sync branch June 9, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants