Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add generate-proof-input for Transfer #133

Merged
merged 12 commits into from
Jun 28, 2022
Merged

feat: Add generate-proof-input for Transfer #133

merged 12 commits into from
Jun 28, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 24, 2022 •
edited
Loading

Adds public input generation to Transfer.

Closes: #114

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jun 24, 2022
@BoyuanFeng BoyuanFeng added this to the v0.5.3 milestone Jun 24, 2022
@BoyuanFeng BoyuanFeng self-assigned this Jun 24, 2022
@BoyuanFeng BoyuanFeng requested review from bhgomes and tsunrise June 24, 2022 22:29
bhgomes
bhgomes suggested changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add the compatibility test.

bhgomes
bhgomes suggested changes Jun 28, 2022
View reviewed changes
bhgomes and others added 2 commits June 27, 2022 21:29
@BoyuanFeng BoyuanFeng requested a review from bhgomes June 28, 2022 01:35
@BoyuanFeng BoyuanFeng merged commit 1c00559 into main Jun 28, 2022
@BoyuanFeng BoyuanFeng deleted the feat/transfer-generate--proof-input branch June 28, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@tsunrise tsunrise tsunrise approved these changes

Assignees

@BoyuanFeng BoyuanFeng

Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.

Add Public Input Generation to Transfer
3 participants
@BoyuanFeng @bhgomes @tsunrise