Remove feature(specialization) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature(specialization) as currently implemented in nightly Rust is known to be unsound. Furthermore, using specialization for Trace was also forcing any downstream crate that implements Trace to itself enable feature(specialization). This made turning on the nightly crate feature a backwards-incompatible change that violates additivity of features, and would cause compilation problems under feature unification. Fixes Manishearth#128. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature(specialization)as currently implemented in nightly Rust is known to be unsound.Furthermore, using specialization for
Tracewas also forcing any downstream crate that implementsTraceto itself enablefeature(specialization). This made turning on thenightlycrate feature a backwards-incompatible change that violates additivity of features, and would cause compilation problems under feature unification.Fixes #128.