Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build for docs.rs by turning on feature only on docs.rs builds #16

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

t4lz
Copy link
Contributor

@t4lz t4lz commented Nov 24, 2024

Another go at #14

In my last PR I didn't think about the fact that with that approach the crate would only build on nightly.

With the new change in this PR the crate builds successfully on stable, and the docs build successfully with the command from the docs.rs build logs (which uses nightly).

@Manishearth
Copy link
Owner

I believe the actual doccfg lines should also be gated on docsrs

@t4lz
Copy link
Contributor Author

t4lz commented Nov 25, 2024

I believe the actual doccfg lines should also be gated on docsrs

That line is already gated:

#[cfg_attr(docsrs, doc(cfg(feature = "camino")))]

Or maybe I don't get what you mean

@Manishearth
Copy link
Owner

Ah! Yes.

@Manishearth Manishearth merged commit 695a66b into Manishearth:master Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants