Add FrozenIndexMap and FrozenIndexSet #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example: StringInterner
pczarn
commented
Nov 13, 2020
Cargo.toml
Outdated
| @@ -10,5 +10,9 @@ repository = "https://github.com/manishearth/elsa" | |||
| keywords = ["data-structure", "map", "frozen", "cache", "arena"] | |||
| categories = ["data-structures", "caching"] | |||
|
|
|||
| [features] | |||
| default = ["indexmap"] | |||
There was a problem hiding this comment.
Should the feature be on by default, or not?
There was a problem hiding this comment.
No extra dependencies by default, please
|
I did the right Cargo.toml, travis and README changes for the string_interner example. (in the last commit) |
pczarn
force-pushed
the
frozen_index_map_set
branch
from
a38f8b2 to
0a46740
Compare
|
Looks great, thank you! Sorry for the delay in reviewing! |
|
Feel free to open a PR that releases version 1.4 |
Merged
|
@Manishearth, I took the liberty of putting up the bump PR (#11) because I would really like to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
The
StringInterner::get_or_internhas an unnecessary call toto_stringwhich allocates. There is no clean workaround, AFAIK. We would need an improved Entry API. See also ideas such asentry_or_clone: Extend entry API to work on borrowed keys rust-lang/rfcs#1769Yet another nice-to-have thing would be a stable custom allocation story. With custom allocators, we could easily replace the meat of the
string_internercrate. Each interner would hold its own allocator, thereby gaining top performance.