Some cleaning up

[hdhoang]

No description provided.

[laumann]

Thanks :-) I'm hesitant to merge this for some reasons:

1. I have to admit, I don't like how rustfmt does some of its work, case in point:

panic!(
    "Cannot link to dependencies. Problem with env var '{}': {:?}",
    varname,
    e
)

when that should clearly be only line. The hanging ) on its own line just irks my eye.

2. The other three commits (a90c251, 1985d02, 4a18ef0) are good in themselves, and I would suggest to submit 1985d02 (and maybe ac544c7) to rustc's compiletest and have them integrated there before merging them here.

Overall, this project tries to keep current with rustc's compiletest (not overeagerly though). I'm happy to take features that extend the tool with options that quite likely will not go back into rustc/compiletest (eg link_deps() and tmp feature). Modifications to the tool's core functionality (even formatting, etc) I think should be implemented in rustc's compiletest before being integrated here.

My suggestion: Pull 4a18ef0 and a90c251 into their own PR and I'll take them. 1985d02 should definitely go into rustc/compiletest, and, although I'm not a fan of rustfmt, if ac544c7 lands in rustc/compiletest, it'll eventually land here as well.

[hdhoang]

Thank you for your review, I have taken your suggestion, and also put a note into the README explaining this situation.

[laumann]

Thanks! And thanks for adding the text in the README - I was just thinking that something like that should be added, so thanks for taking care of that for me 😄