Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustup https://github.com/rust-lang/rust/pull/58689 #160

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Rustup https://github.com/rust-lang/rust/pull/58689 #160

merged 1 commit into from
Mar 3, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Mar 1, 2019 •
edited
Loading

Fix for the next (not yet released) nightly.

Fixes #159

@Xanewok Xanewok mentioned this pull request Mar 1, 2019
Merged
@mati865
Copy link
Contributor Author

mati865 commented Mar 2, 2019

Let's make the CI green.

@mati865 mati865 closed this Mar 2, 2019
@mati865 mati865 reopened this Mar 2, 2019
@mati865
Copy link
Contributor Author

mati865 commented Mar 2, 2019

Should I add cfg checking for stable feature to this field?

@mati865 mati865 mentioned this pull request Mar 2, 2019
Closed
@Xanewok Xanewok mentioned this pull request Mar 2, 2019
Merged
@laumann
Copy link
Collaborator

laumann commented Mar 3, 2019

Hi @mati865, thanks for opening this PR!

Should I add cfg checking for stable feature to this field?

Yeah, that looks to be necessary.

@mati865
Copy link
Contributor Author

mati865 commented Mar 3, 2019

All green.

@rchaser53 rchaser53 mentioned this pull request Mar 3, 2019
Closed
@Xanewok
Copy link

Xanewok commented Mar 3, 2019

If merged, please do a point release (so that we can fix Clippy and RLS without some of the branch acrobatics required across multiple repositories), thanks!

@laumann
Copy link
Collaborator

laumann commented Mar 3, 2019

All green.

Awesome, thanks!

If merged, please do a point release (so that we can fix Clippy and RLS without some of the branch acrobatics required across multiple repositories), thanks!

Will do.

@laumann
Copy link
Collaborator

laumann commented Mar 3, 2019

@Xanewok @mati865 Just for me to get the timeline right: When this PR was created, the nightly this fix is inteded for wasn't released yet, but it now, right?

@laumann laumann merged commit 3c92747 into Manishearth:master Mar 3, 2019
@mati865
Copy link
Contributor Author

mati865 commented Mar 3, 2019

@Xanewok @mati865 Just for me to get the timeline right: When this PR was created, the nightly this fix is inteded for wasn't released yet, but it now, right?

Exactly.

@mati865 mati865 deleted the rustup branch March 3, 2019 14:45
@laumann
Copy link
Collaborator

laumann commented Mar 3, 2019

@Xanewok @mati865 Version 0.3.19 is out!

@Xanewok
Copy link

Xanewok commented Mar 3, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mati865 @laumann @Xanewok