Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoaliasattr): Implement Documentation of TypeVar's #3818

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jun 22, 2024

@JasonGrace2282 JasonGrace2282 requested a review from chopan050 June 22, 2024 03:11
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left some minor suggestions around the code.
As a side note, I noticed that I myself missed some things regarding backreferences and format in #3484, such as some :class: or ~typing. prefixes and using single instead of double backticks for some names, and I'd like to make a separate PR fixing them

manim/utils/docbuild/module_parsing.py Outdated Show resolved Hide resolved
manim/utils/docbuild/module_parsing.py Outdated Show resolved Hide resolved
manim/utils/docbuild/module_parsing.py Show resolved Hide resolved
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chopan050 chopan050 enabled auto-merge (squash) June 26, 2024 14:43
@chopan050 chopan050 merged commit 93a20cd into ManimCommunity:main Jun 26, 2024
17 of 18 checks passed
@JasonGrace2282 JasonGrace2282 deleted the typevar branch June 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Autoaliasattr: TypeVar
2 participants