fix: importing manim should not trigger pygments.styles.get_all_styles #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the Code.styles_list attribute. Rewrote the documentation to say that a list of all styles can be generated by calling list(pygments.styles.get_all_styles()). The example in the docstring of Code was rewritten to use an explicit code style name.
|
Hey, I'll take a look at this within the next few days, as I'm a bit busy right now. Just wanted to let you know that we see this PR and intend to review it :) |
JasonGrace2282
requested changes
Jun 10, 2024
Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com>
Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com>
JasonGrace2282
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Removed the
Code.styles_listattribute.Added new class method
Code.get_styles_list().Rewrote the documentation to say that a list of all styles can be generated by calling a new class method.
The example in the docstring of Code was rewritten to use an explicit code style name.
Motivation and Explanation: Why and how do your changes improve the library?
See #3713 for issue.
Links to added or changed documentation pages
https://manimce--3797.org.readthedocs.build/en/3797/
Further Information and Comments
First contribution!
Reviewer Checklist