[EUWE] Add decorator for VNC Console #16377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles. https://bugzilla.redhat.com/show_bug.cgi?id=1505546
|
Checked commit jntullo@1d61538 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Wanted to briefly check on the status of thisssssssssssssssssssssssssssss 😬 🎁 💝 |
|
Waiting for approval from @abellotti Travis is broken for Euwe branch right now, so I will re-run the test once that's fixed. |
|
🚶 🏖 🐚 🌺 💌 💃 @abellotti ❓ |
abellotti
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles.
https://bugzilla.redhat.com/show_bug.cgi?id=1505546
Related:
ManageIQ/manageiq-api#167
ManageIQ/manageiq-ui-service#1195
@miq-bot add_label bug, euwe/yes
@miq-bot assign @simaishi
cc: @AllenBW