Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove capybara testing framework #14728

Closed
wants to merge 1 commit into from
Closed

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 11, 2017

I couldn't find a features directory or any reference to this library.

Since this is only used in the test environment, it doesn't affect production.

I just want to remove it since it references mime-type gem and gets loaded when we run tests.

@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2017

Checked commit kbrock@a44a293 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@Fryguy
Copy link
Member

Fryguy commented Apr 11, 2017

capybara is not features...that's cucumber. capybara is for methods like visit and such, which is used by the UI. Can you verify that the UI tests run with the change? If not, then capybara should probably move there (though that doesn't solve your mime_types problem).

Coincidentally, I tried changing capybara recently to remove mime_types, and found a bug in mini_mime. See discourse/mini_mime#3 . That was released as 0.1.3, but I haven't had a chance to get back to updating capybara.

@kbrock
Copy link
Member Author

kbrock commented Apr 11, 2017

ugh. thanks. (I knew this at one time...)

I'll look at adding this to the ui project.

If nothing else, jasmine and capybara should be over there.

@kbrock
Copy link
Member Author

kbrock commented May 8, 2017

I'll let someone else deal with this

@kbrock kbrock closed this May 8, 2017
@kbrock kbrock deleted the gem_capybara branch May 8, 2017 21:38
@chrisarcand
Copy link
Member

I'm pretty sure I opened this exact PR with these exact changes a year ago 😄

... 😭

@kbrock
Copy link
Member Author

kbrock commented May 12, 2017

But features are cucumber. So I was a little confused :(

Still think these should not be in the main repo

@Fryguy
Copy link
Member

Fryguy commented Jun 28, 2017

@kbrock Related: teamcapybara/capybara#1884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants