Fix history button in vm infra page #12614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I'm seeing |
ZitaNemeckova
force-pushed
the
fix_history_button_vm
branch
2 times, most recently
from
dcc3eed to
4ac07e4
Compare
|
LGTM, tested in the UI, fixes the bug 👍 |
ZitaNemeckova
force-pushed
the
fix_history_button_vm
branch
from
4ac07e4 to
9b727fc
Compare
|
Checked commit ZitaNemeckova@9b727fc with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Nov 16, 2016
Fix history button in vm infra page (cherry picked from commit 804cf5e) https://bugzilla.redhat.com/show_bug.cgi?id=1393708
|
Euwe Backport details: $ git log -1
commit adbe1faf05a8cf6c6fd01a7a1e87827c7b5ba6e9
Author: Martin Hradil <himdel@seznam.cz>
Date: Wed Nov 16 14:19:51 2016 +0200
Merge pull request #12614 from ZitaNemeckova/fix_history_button_vm
Fix history button in vm infra page
(cherry picked from commit 804cf5e66e28d6370333148c4f2affc47a61de35)
https://bugzilla.redhat.com/show_bug.cgi?id=1393708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #11387
Compute -> Infrastructure -> Virtual Machine
Click on any VM
Click on its Snapshots
Click on another node in left tree
Click back button and choose one with
SnapshotsAll
x_history_add_itemthat take id of VM/Template were corrected.(
aais a VM,centos-6-v20150325is parent node of VM.)Before:
Snapshots of parent node of VM.
After:
Snapshots of VM.
This PR needs #12504 to work.
https://bugzilla.redhat.com/show_bug.cgi?id=1393708
@miq-bot add_label ui, bug, blocker, euwe/yes