Implement Generic Objects on services details page #996

chalettu · 2017-09-20T21:48:44Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1497705

chalettu · 2017-09-20T21:51:03Z

@miq-bot add_label enhancement
@miq-bot add_label fine/no

chalettu · 2017-09-20T21:52:05Z

Here is a sample screenshot of the implementation of Generic Objects, @chriskacerguis . Keep in mind this does not currently show the custom actions drop down yet.

chriskacerguis · 2017-09-20T22:52:36Z

@bascar FYI - Some great progress from @chalettu

chriskacerguis · 2017-09-20T23:02:28Z

@chalettu can you please attach the issue to this PR?

chalettu · 2017-09-21T14:42:14Z

#934

serenamarie125 · 2017-09-21T21:34:00Z

@chalettu looking good. I know this is WIP, but since it has the ux/review tag i assume you want me to provide feedback on what you have

The main accordion showing the generic object type should have parens with the # of generic objects of that type, similar to the Compute resources shown above.
the collapsed Generic Object List view item should show the Generic object type icon before the name of the object
is it possible for you to put 4 key/value pairs for mock data so that we can see the alignment of the information ?

Loicavenel · 2017-09-22T06:33:12Z

@bascar do you have some example of Key/Value = Generic Object Properties we may have.. Today we have 3 on one line and Serena is suggesting may be 4.. Do you know what is the limit engineering put in the DB for a a key and a Value.. 255?

serenamarie125 · 2017-09-22T12:27:57Z

@chalettu @Loicavenel @bascar regarding my #3 comment, I didn't mean we should show 4 pairs on a row, having 3 on a row is sufficient.

I'm suggesting that we have dummy data for 4 key/value pairs that are used and added as a mockup to understand what it looks like. It would be great to have some real examples from Brad so that Chris can show them here though!

bascar · 2017-09-22T14:09:10Z

There is no limit to the pairs as it is all a JSON payload made to look like attributes.
Examples of some could be:
arn => arn:aws:rds:eu-west-1:123456789012:db:mysql-db
dept => Finance
cost_center => 4567890
retry_attempts => 123
cleanup_playbook=> https://github.com/somproject/helpers/blob/master/tools/somecleanupscript.yml
......

chalettu · 2017-09-25T19:15:38Z

Currently awaiting ManageIQ/manageiq-api#57 that will allow subcollections on Generic Objects
Also currently awaiting the Generic Object custom actions functionality to be completed. No PR as of yet.

chriskacerguis · 2017-09-28T17:35:51Z

@chalettu this needs to get bumped in test coverage :)

chriskacerguis · 2017-09-29T15:37:55Z

@bascar @Loicavenel FYI - This is blocked until ManageIQ/manageiq-api#57 is merged

bascar · 2017-09-29T18:27:55Z

I asked nicely for a merge, thanks @chriskacerguis

chriskacerguis · 2017-10-02T13:47:49Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1497705

chriskacerguis · 2017-10-03T18:38:26Z

@chalettu could we add some tests for this?

chalettu · 2017-10-03T20:40:28Z

@chriskacerguis we are also dependent on ManageIQ/manageiq-api#93 for implementing custom actions on Generic Objects

serenamarie125 · 2017-10-04T02:13:54Z

Is there any way we can see what this will look like with more pairs? Brad provided some. It would be nice to see what it'll look like. I'm concerned about alignment, and would rather see that now if possible than later.

chalettu · 2017-10-05T19:58:59Z

@serenamarie125 here is the latest Screenshot of GO that implements custom actions. Please let me know if we have any revisions we would like to make.

chalettu · 2017-10-06T21:21:26Z

We are going to add generic object icon support after ManageIQ/manageiq-api#114 gets merged in. This will allow us to show custom pictures

serenamarie125 · 2017-10-16T23:33:32Z

@chalettu the reason I asked about seeing what this looks like with more pairs of data is because my mocks (shown here) have the label left aligned rather than right aligned as you have implemented. This may be perfectly acceptable, but I wanted to see what it looks like.

chalettu · 2017-10-17T22:04:30Z

@serenamarie125 here is a updated screenshot that includes Generic object picture support and also for multiple generic object attributes. Please let me know if you approve of the UI.

chalettu · 2017-10-17T22:05:48Z

@miq-bot remove_label wip

chriskacerguis · 2017-10-18T19:13:01Z

@serenamarie125 I spoke to @chalettu this is good for your review :)

/cc @bascar @Loicavenel

serenamarie125

LGTM @chalettu nice work! Once this is merged, I may take another pass at a high fidelity review, but this looks great as far as functionality is concerned

serenamarie125 · 2017-10-18T23:35:44Z

@miq-bot add_labels ux/approved

serenamarie125 · 2017-10-18T23:35:57Z

@miq-bot remove_labels ux/review

miq-bot · 2017-10-19T13:43:10Z

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/b6547b599492e33b52b2aa18c28d8dabb951a864~...eff6bb53659fe29fa7b750cd2d64063bf65bd9c1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

AllenBW

Only the one thing jumps out, overall loooooks 🌮 💃 !!!

AllenBW · 2017-10-19T14:10:28Z

client/app/services/generic-objects-list/generic-objects-list.html

+                 ng-click="$ctrl.customScope.toggleExpand(item)">
+              <i class="fa fa-angle-right"
+                 ng-class="{'fa-angle-down': item.isExpanded}"></i>
+                 <img src="{{item.picture.image_href}}" class="generic-object-icon" ng-if="item.picture">


prefer use of ng-src here, while this probably will work most of the time, this should be done for the one time the browser will still try to load the {{path}} string it finds in <img src="{{path}}">

AllenBW

🌮 💃

chalettu requested review from AllenBW and chriskacerguis as code owners September 20, 2017 21:48

miq-bot added enhancement fine/no labels Sep 20, 2017

miq-bot added the wip label Sep 20, 2017

chriskacerguis self-assigned this Sep 20, 2017

chriskacerguis added the ux/review label Sep 20, 2017

chalettu changed the title ~~[WIP] Implement Generic Objects on services details page~~ Implement Generic Objects on services details page Oct 17, 2017

miq-bot removed the wip label Oct 17, 2017

serenamarie125 approved these changes Oct 18, 2017

View reviewed changes

miq-bot added ux/approved and removed ux/review labels Oct 18, 2017

chriskacerguis previously approved these changes Oct 18, 2017

View reviewed changes

chriskacerguis added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 18, 2017

chalettu added 7 commits October 19, 2017 07:40

Implemented Generic Objects on services details page

b6547b5

Updated to support generic object actions

10723a9

Added support for Generic object pictures

ea3b2ff

Updated tests

1df7ab5

Updated Tests to support testing generic objects

38b81c8

Updated attribute layout

ee90e4b

Made picture optional

eff6bb5

chalettu dismissed chriskacerguis’s stale review via eff6bb5 October 19, 2017 13:41

chriskacerguis previously approved these changes Oct 19, 2017

View reviewed changes

AllenBW suggested changes Oct 19, 2017

View reviewed changes

changed image src to ng-src

fc3e4f2

chalettu dismissed chriskacerguis’s stale review via fc3e4f2 October 19, 2017 17:34

AllenBW approved these changes Oct 19, 2017

View reviewed changes

chriskacerguis approved these changes Oct 19, 2017

View reviewed changes

chriskacerguis merged commit 58f0c0a into ManageIQ:master Oct 19, 2017

chalettu deleted the generic-objects branch January 10, 2018 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Generic Objects on services details page #996

Implement Generic Objects on services details page #996

chalettu commented Sep 20, 2017 •

edited by chriskacerguis

Loading

chalettu commented Sep 20, 2017

chalettu commented Sep 20, 2017

chriskacerguis commented Sep 20, 2017

chriskacerguis commented Sep 20, 2017

chalettu commented Sep 21, 2017

serenamarie125 commented Sep 21, 2017

Loicavenel commented Sep 22, 2017

serenamarie125 commented Sep 22, 2017

bascar commented Sep 22, 2017

chalettu commented Sep 25, 2017

chriskacerguis commented Sep 28, 2017

chriskacerguis commented Sep 29, 2017

bascar commented Sep 29, 2017

chriskacerguis commented Oct 2, 2017

chriskacerguis commented Oct 3, 2017

chalettu commented Oct 3, 2017

serenamarie125 commented Oct 4, 2017

chalettu commented Oct 5, 2017

chalettu commented Oct 6, 2017

serenamarie125 commented Oct 16, 2017 •

edited

Loading

chalettu commented Oct 17, 2017

chalettu commented Oct 17, 2017

chriskacerguis commented Oct 18, 2017

serenamarie125 left a comment

serenamarie125 commented Oct 18, 2017

serenamarie125 commented Oct 18, 2017

miq-bot commented Oct 19, 2017

AllenBW left a comment

AllenBW Oct 19, 2017

AllenBW left a comment

Implement Generic Objects on services details page #996

Implement Generic Objects on services details page #996

Conversation

chalettu commented Sep 20, 2017 • edited by chriskacerguis Loading

chalettu commented Sep 20, 2017

chalettu commented Sep 20, 2017

chriskacerguis commented Sep 20, 2017

chriskacerguis commented Sep 20, 2017

chalettu commented Sep 21, 2017

serenamarie125 commented Sep 21, 2017

Loicavenel commented Sep 22, 2017

serenamarie125 commented Sep 22, 2017

bascar commented Sep 22, 2017

chalettu commented Sep 25, 2017

chriskacerguis commented Sep 28, 2017

chriskacerguis commented Sep 29, 2017

bascar commented Sep 29, 2017

chriskacerguis commented Oct 2, 2017

chriskacerguis commented Oct 3, 2017

chalettu commented Oct 3, 2017

serenamarie125 commented Oct 4, 2017

chalettu commented Oct 5, 2017

chalettu commented Oct 6, 2017

serenamarie125 commented Oct 16, 2017 • edited Loading

chalettu commented Oct 17, 2017

chalettu commented Oct 17, 2017

chriskacerguis commented Oct 18, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

serenamarie125 commented Oct 18, 2017

serenamarie125 commented Oct 18, 2017

miq-bot commented Oct 19, 2017

AllenBW left a comment

Choose a reason for hiding this comment

AllenBW Oct 19, 2017

Choose a reason for hiding this comment

AllenBW left a comment

Choose a reason for hiding this comment

chalettu commented Sep 20, 2017 •

edited by chriskacerguis

Loading

serenamarie125 commented Oct 16, 2017 •

edited

Loading