[Finishes #150828440] Reconfigures tag query to prevent explorer filter failure #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskacerguis
approved these changes
Sep 5, 2017
chriskacerguis
previously requested changes
Sep 5, 2017
…er failure Without, when a user who does not have product features to see/use tags, no filter fields are presented
AllenBW
force-pushed
the
hotfix/service-failed-tag-filter
branch
from
febf0b2 to
0f505eb
Compare
|
Ugh. Coveralls is stupid. |
AllenBW
force-pushed
the
hotfix/service-failed-tag-filter
branch
from
c5d58c6 to
99a012f
Compare
|
Checked commits AllenBW/manageiq-ui-service@0f505eb~...99a012f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without, when a user who does not have product features to see/use tags, no filter fields are presented. No ux changes
User with tag permissions
User without tag permissions (before this fix)
User without tag permissions (fixed in this pr)