BZ#1470868 PT#148992591 Adds filter alias to dashboard retirement buttons #884
Conversation
AllenBW
requested review from
chalettu,
chriskacerguis,
Loicavenel and
serenamarie125
|
This pull request is not mergeable. Please rebase and repush. |
AllenBW
force-pushed
the
BZ/1470868-retirement-filter-alias
branch
from
245da4d to
3ea6597
Compare
|
Checked commit AllenBW@3ea6597 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@chriskacerguis This can totally get in now! 💃 |
|
good for me |
|
@AllenBW There's not a lot of description here as to what you've done, so instead of me commenting on things which are unrelated to this PR, can you explain what has been changed with this PR? (for example a colon is included in the retirement filter chips now, is that due to this PR)> |
|
@serenamarie125 this pr fulfilled the ask of the linked ref (:bee::zzz:). Above you see the after, here is the before:
Colons were always there, can't really change them, but now we use words instead of long alpha numeric strings |
|
The fact that we can get directly from the dashboard to a filtered view for Retiring Soon & Not Retired makes me 😃 👍 @AllenBW I've never seen a time based filter work like this ... is that what you've added? I'm just concerned with the fact that the filter chips/pills ( whatever we call them ) don't make much sense. If this was there before, let me know and I will approve this PR and open an Issue. |
|
@serenamarie125 Yeah this (from dashboard to filtered view) was there before, except it made even less sense (above screen shot) cuz the filter values couldn't be aliased (meaning we had to see the raw value). If there is wording you would feel better communicates the three selections, |
https://www.pivotaltracker.com/story/show/148992591
https://bugzilla.redhat.com/show_bug.cgi?id=1470868
Unmergable till #873 makes it in@Loicavenel @serenamarie125 @chriskacerguis please checkout wording, maybe change it to something else?
🌮 💃
can totally merge this one in now!