Display colored fonticons before custom buttons #851
Conversation
|
@chriskacerguis i think should should have a ux/review tag on it along with a UX review? |
|
@serenamarie125 /agree :) |
|
@serenamarie125 I've added the label, but it looks like this is still WIP. |
|
@chriskacerguis I market it as WIP because of #850 |
|
@skateman ahhh...thanks for clarifying. |
|
@chriskacerguis understood, but having visibility to what's being worked on is helpful, thank you! |
|
@serenamarie125 makes sense to me :) |
| @@ -4,6 +4,7 @@ | |||
| ng-click="vm.invokeCustomAction(button)" | |||
| uib-tooltip="{{button.description}}" | |||
| tooltip-placement="top"> | |||
| <i ng-class="button.options.button_icon" ng-style="{color: button.options.button_color }"></i> | |||
There was a problem hiding this comment.
Skeptical about use of why is this necessary?
There was a problem hiding this comment.
@AllenBW I can add some padding-right instead
There was a problem hiding this comment.
So has the API been updated to send the icons in the custom button API response?
skateman
force-pushed
the
custom-button-icons-colors
branch
from
0ec980f to
33a10e1
Compare
skateman
changed the title
skateman
force-pushed
the
custom-button-icons-colors
branch
from
33a10e1 to
3a85b15
Compare
|
Checked commit skateman@3a85b15 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Rebased, ready to merge! |
|
@serenamarie125 ready for review :) |
|
What am i supposed to be reviewing here :) I haven't seen any icon picker, is that it? I see one image with a green star, but 👀 unsure |
|
@serenamarie125 that's the thing 😉 we're just displaying the icons in the SUI and the picker will be used in the OPS UI only. |
|
@serenamarie125 echoing the same thing that @skateman said, since this is just the SUI...it is just showing the icons...not picking them. I think that the image is showing what the button with an icon / color will look like in the SUI. |
Pivotal story in the OPS UI: https://www.pivotaltracker.com/story/show/147779325
Depends on: ManageIQ/manageiq-schema#39
Some icons might be not displayed becauseof this: #850