Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ 1467569- in the self service portal after a little time displaying a vm, data changes to garbage data #842

Merged
merged 1 commit into from
Jul 12, 2017
Merged

BZ 1467569- in the self service portal after a little time displaying a vm, data changes to garbage data #842

merged 1 commit into from
Jul 12, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Jul 12, 2017 •
edited by simaishi
Loading

No UX changes. This fixes an issue with polling causing issues with data not rendering properly

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1467569

@chalettu chalettu requested a review from chriskacerguis as a code owner July 12, 2017 17:09
@chalettu
Copy link
Contributor Author

@miq-bot add_label bug
@miq-bot add_label services
@miq-bot add_label fine/yes

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2017

@chalettu Cannot apply the following label because they are not recognized: services

@chalettu
Copy link
Contributor Author

@miq-bot add_label my services

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/3a4d45c7d7c8b203c3da02650e755a15bd845e57 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chriskacerguis chriskacerguis added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 12, 2017
@chriskacerguis chriskacerguis self-assigned this Jul 12, 2017
@chriskacerguis chriskacerguis merged commit 2604c93 into ManageIQ:master Jul 12, 2017
@simaishi simaishi added blocker and removed bug labels Jul 13, 2017
@simaishi
Copy link
Contributor

simaishi commented Jul 13, 2017 •
edited
Loading

@chalettu There are conflicts backporting in vm-details.html, but it looks like I can just change ng-if to display-field in bunch of details-reveal. I have to skip one or two because ng-if isn't used for it in Fine branch. Please confirm that's ok (or you can create a PR for Fine branch if you'd prefer that way).

simaishi pushed a commit that referenced this pull request Jul 13, 2017
@chriskacerguis @simaishi
Merge pull request #842 from chalettu/vm-details-bug
18c8e0d 
BZ 1467569- in the self service portal after a little time displaying a vm, data changes to garbage data
(cherry picked from commit 2604c93)

https://bugzilla.redhat.com/show_bug.cgi?id=1470774
@simaishi
Copy link
Contributor

@chalettu Thanks for the confirmation on gitter... please double-check the changes backported.

Fine backport details:

$ git log -1
commit 18c8e0db1c5a983b47a7eb27b67a0fc9272794a2
Author: Chris Kacerguis <chriskacerguis@users.noreply.github.com>
Date:   Wed Jul 12 13:24:07 2017 -0400

    Merge pull request #842 from chalettu/vm-details-bug
    
    BZ 1467569- in the self service portal after a little time displaying a vm, data changes to garbage data
    (cherry picked from commit 2604c93bcc7bcf4972c7e20b53c959e6e97728a3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1470774

@AllenBW AllenBW mentioned this pull request Aug 15, 2017
Merged
@chalettu chalettu deleted the vm-details-bug branch December 20, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
blocker fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @simaishi @chriskacerguis