Pt#147640893 - redesign vm details #831
Conversation
|
@ManageIQ/core-ux for your review /cc @Loicavenel |
|
@AllenBW this is good 🍣 |
|
@AllenBW can you please address the travis fail? |
|
Yeah that's odd, not failing locally 🤔 |
Ensure color import uses explicit path, while not necessary, it makes jetbrains happy.
Adds scroll overflow behavior to detail-rows, formats some html
TODO: dignostics and smart management
AllenBW
force-pushed
the
PT/#147640893-redesign-vm-details
branch
from
64ad1b3 to
677e0d2
Compare
|
@chriskacerguis yeah that should feel better 🌮 😋 |
|
Checked commits AllenBW/manageiq-ui-service@90bfae4~...dc4febc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@ManageIQ/core-ux for your review /cc @Loicavenel |
|
First comment is about Smart Tags.. at Service level it is different... we should remain consistent.. |
|
@Loicavenel Dont quite follow, a different level? |
|
@AllenBW the way we represent Tags at Service level (blue boxes) is different at the VM level (a table) |
|
Ah @Loicavenel the inconsistency below: A few comments on the comment:
|
|
@AllenBW yes, this is what I am talking about.. So, we introduced this blue box concept (I like it) which does not exist in OpsUI (Or I never saw it) but in VMS, we do as Ops UI.... This is inconsistent for me... Now, I understand this require some guidance |
|
These mocks were provided a ways back, and had no input from PM. Let's discuss |
|
I think that this goes back to the thought that we were introducing new elements into the SUI that would be later brought into the Ops UI. This is not the only place that we are showing tags this way in the SUI. If i remember right, chris hale or josh worked on a component with colleen on this a ways back. |
|
@serenamarie125 Correct, Josh and I worked on a common design pattern for Tags that we were looking to first implement throughout the SUI and add follow up stories to implement in the Ops UI. The design can be found HERE on the design repo under the Common Components section. |
|
@serenamarie125 this was my point we should use the same pattern for all SUI when is about Tags :) |
|
So we have a meet setup to talk about the tags, thinking adjusting falls outta scope of the original ask of this pr, which was to make vm-details look like the mocks we presently had. Given ☝️ @Loicavenel @serenamarie125 @chriskacerguis, I propose we merge this and do the additional work in a future pr. |
|
@serenamarie125 @Loicavenel so, I setup a meeting to discuss, regardless of the outcome of that meeting it would be a separate PR to address the look / feel of the tags. Can we agree that this can go in (as it does fit the current UX design) and once we have consensus we will address the tag look and feel? /cc @chessbyte |
|
@chriskacerguis Ok, can we have a screenshot from other type of VM... Windows on wmware, Amazon instance for example |
|
@allewbw could you help with that? |
|
yeah! i'll get on that monday... 5 prs in a day is enough for me 😩 🤘 |
|
Here are a few more fotos of different provider types, (all i have in my db) @chriskacerguis @Loicavenel |
|
This pull request is not mergeable. Please rebase and repush. |
|
Added new UX to the story. Closing this PR. |
|
le sigh. 831, I will not forget you |
https://www.pivotaltracker.com/story/show/147640893
Brings service details closer to the mock mentioned in the pt.
In ops rows occasionally link to other views, this task was NOT done as part of this pr.
RBAC implemented where applicable.
There are a few icons/tiny images yet to do on this pr, but wanted to get the bulk of this out there
Da gooooooodddzzzzzzzz
shout out to @jntullo for api 🛍 ⛑
Odds and end this fixes:
app_colorsrather thancolors