Adds create snapshot button on service details page #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Loicavenel @serenamarie125 💃 🇰🇿 🌘 |
AllenBW
force-pushed
the
PT/#145848829-service-details-create-snapshot
branch
from
8cf9570 to
c170fc5
Compare
|
looks good for me.. we need final signe off from @serenamarie125 |
|
@AllenBW travis fail. |
|
@AllenBW also, test coverage drops (not a massive drop, but maybe we can do something to improve it?) |
|
@chriskacerguis hmm... well we already have a spec for the component (process-snapshot-modal.component)... i can write a spec for another file to make up for loss if that's acceptable |
Button obeys rbac Follows mocks specified here: https://docs.google.com/document/d/1YBi1rk5qBHqyTVrx1uN4f_JLRbAUZ27uUngwgsqP7mE/edit
Reconfigures service-explorer onInit to support testing
AllenBW
force-pushed
the
PT/#145848829-service-details-create-snapshot
branch
from
3982505 to
4811601
Compare
|
Checked commits AllenBW/manageiq-ui-service@2138152~...4811601 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/1914499
Button obeys rbac
Follows mocks specified here
Wat it lookz like, you'll notice this now follows mocks