settings.help_menu.documentation - Fix missing href "Cannot read property 'match' of undefined" #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty 'match' of undefined" The code assumes settings.help_menu.documentation contains a href, and fails without it. But the href is there only if we want to override the link, fixing. Also, the original code expects the href to always be http://api_location/api/http://the_href.com , now it will parse that if present, but fall back to just using the href if not.
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/638d47107d01e8810f0f3a725046c708784d45e5 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumes
settings.help_menu.documentationcontains a href, and fails without it.But the href is there only if we want to override the link, fixing.
Also, the original code expects the href to always be http://api_location/api/http://the_href.com ,
now it will parse that if present, but fall back to just using the href if not.
(I do not see any ui-classic references to the setting.)