BZ#1653193 - Custom buttons - only show button name when the "Display on Button" option is set #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/e75b111885aa31bd23f7ef026ce3cae16e6c2ec4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
changed the title
AllenBW
approved these changes
Nov 29, 2018
|
Yup, looks like we're not using the same toolbar in SUI yet, for better or worse :). (I'm guessing this is because the CUI toolbar relies on having the data preprocessed by the ruby side, instead of reading from the API) |
simaishi
pushed a commit
that referenced
this pull request
Dec 3, 2018
BZ#1653193 - Custom buttons - only show button name when the "Display on Button" option is set (cherry picked from commit 71856b0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2018
BZ#1653193 - Custom buttons - only show button name when the "Display on Button" option is set (cherry picked from commit 71856b0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655772
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show custom button names when the "Display on Button" option is set.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193