BZ#1637512-Restore action cable subscription, ensure enablement flag is available #1482

AllenBW · 2018-10-09T18:49:48Z

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637512

Pretty much reimplements #1314, but now its working without errors

what it looks like, but yah really should jump in for yerself

and if you jump in... @skateman provided this wonderfully useful commands... (to be run from rails console)

Notification.create(:type => :generic_task_fail, :subject => Vm.first, :options => {:message => "nil"}, :user_id => User.first.id)

or

Notification.last.send(:emit_message)

skateman · 2018-10-10T08:05:48Z

@AllenBW the ActionCable is initialized in one more place:

$ ag cable.subscriptions.create
client/app/states/login/login.state.js
79:      cable.subscriptions.create('NotificationChannel', {})

client/app/core/authorization.config.js
96:      cable.subscriptions.create('NotificationChannel', {})

AllenBW · 2018-10-10T10:39:14Z

@skateman good catch, doesn't change behavior in above gif, updated!

skateman · 2018-10-10T11:14:01Z

@AllenBW okay, but what if you force the refresh of a page (F5)?

AllenBW · 2018-10-10T11:41:35Z

@skateman its all ok when you force refresh of a page (F5). I did that, then sent a notification, it showed up.

skateman · 2018-10-10T11:46:52Z

but travis doesn't 😞

himdel · 2018-10-10T11:57:38Z

10 10 2018 11:45:13.336:WARN [PhantomJS 2.1.1 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.
PhantomJS 2.1.1 (Linux 0.0.0) ERROR
  Disconnected, because no message in 10000 ms.
PhantomJS 2.1.1 (Linux 0.0.0): Executed 6 of 357 DISCONNECTED (11.739 secs / 1.163 secs)
PhantomJS 2.1.1 (Linux 0.0.0) ERROR
  Disconnected, because no message in 10000 ms.
JS 2.1.1 (Linux 0.0.0): Executed 6 of 357 DISCONNECTED (11.739 secs / 1.163 secs)

hopefully just a restart..

skateman · 2018-10-10T12:03:26Z

client/app/core/appliance-info.service.js

@@ -23,7 +23,8 @@ export function ApplianceInfo ($sessionStorage) {
      role: data.identity.role,
      suiVersion: gitHash.gitCommit,
      miqVersion: data.server_info.version + '.' + data.server_info.build,
-      server: data.server_info.appliance
+      server: data.server_info.appliance,
+      asyncNotify: data.settings.asynchronous_notifications || false


This should be true by default, because the feature behind this is to turn it OFF.

skateman · 2018-10-10T12:03:37Z

client/app/core/appliance-info.service.spec.js

@@ -40,7 +40,8 @@ describe('Appliance Info Service', () => {
      'role': 'EvmRole-super_administrator',
      'miqVersion': 'master.20170510164252_9e5df30',
      'suiVersion': '',
-      'server': 'EVM'
+      'server': 'EVM',
+      'asyncNotify': 'false'


true please

fiiineeeeee

AllenBW · 2018-10-10T12:12:01Z

Yah needs a restart, maybe a few, timeouts are killin' travis, not spec fails 😋

AllenBW · 2018-10-10T12:47:22Z

@himdel @skateman see TRAVIS IS A FRIEND NOT FOOD, just needs a lil lovin' 'sall

skateman

himdel

LGTM 👍

A bit worried that we're initializing this in a service constructor,
but verified this service doesn't get instantiated on the login page,
and it is used by menus and the shopping cart, so it will be initialized on every page.

AllenBW · 2018-10-12T14:19:08Z

<3

BZ#1637512-Restore action cable subscription, ensure enablement flag is available (cherry picked from commit 3af8f1b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637512

simaishi · 2018-10-12T15:58:06Z

Hammer backport details:

$ git log -1
commit 0d9b99cffa379f24dc1ba547ba8e8f5f11766b0b
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Oct 12 15:47:04 2018 +0200

    Merge pull request #1482 from AllenBW/bug/#1637512-broken-websockets
    
    BZ#1637512-Restore action cable subscription, ensure enablement flag is available
    
    (cherry picked from commit 3af8f1b78e1fef72ba059ce8552fe048331de03c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637512

BZ#1637512-Restore action cable subscription, ensure enablement flag is available (cherry picked from commit 3af8f1b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639351

simaishi · 2018-11-05T18:00:44Z

Gaprindashvili backport details:

$ git log -1
commit ff4c2c219bbc4e093bdffdcdadeda38d2bddcdd0
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Oct 12 15:47:04 2018 +0200

    Merge pull request #1482 from AllenBW/bug/#1637512-broken-websockets
    
    BZ#1637512-Restore action cable subscription, ensure enablement flag is available
    
    (cherry picked from commit 3af8f1b78e1fef72ba059ce8552fe048331de03c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639351

AllenBW assigned himdel Oct 9, 2018

AllenBW requested review from himdel and skateman October 9, 2018 18:49

AllenBW added bug hammer/yes labels Oct 9, 2018

dclarizio added the gaprindashvili/yes label Oct 9, 2018

AllenBW force-pushed the bug/#1637512-broken-websockets branch from ff34862 to 879ee5b Compare October 10, 2018 10:37

skateman suggested changes Oct 10, 2018

View reviewed changes

Restore action cable subscription, ensure enablement flag is present

a30d4b1

AllenBW force-pushed the bug/#1637512-broken-websockets branch from 879ee5b to a30d4b1 Compare October 10, 2018 12:11

skateman approved these changes Oct 10, 2018

View reviewed changes

himdel approved these changes Oct 12, 2018

View reviewed changes

himdel merged commit 3af8f1b into ManageIQ:master Oct 12, 2018

himdel added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 12, 2018

AllenBW deleted the bug/#1637512-broken-websockets branch October 12, 2018 14:19

simaishi added hammer/backported blocker and removed hammer/yes labels Oct 12, 2018

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Nov 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BZ#1637512-Restore action cable subscription, ensure enablement flag is available #1482

BZ#1637512-Restore action cable subscription, ensure enablement flag is available #1482

AllenBW commented Oct 9, 2018 •

edited

Loading

skateman commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman commented Oct 10, 2018

himdel commented Oct 10, 2018

skateman Oct 10, 2018

AllenBW Oct 10, 2018

skateman Oct 10, 2018

AllenBW Oct 10, 2018

AllenBW commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman left a comment

himdel left a comment

AllenBW commented Oct 12, 2018

simaishi commented Oct 12, 2018

simaishi commented Nov 5, 2018

BZ#1637512-Restore action cable subscription, ensure enablement flag is available #1482

BZ#1637512-Restore action cable subscription, ensure enablement flag is available #1482

Conversation

AllenBW commented Oct 9, 2018 • edited Loading

what it looks like, but yah really should jump in for yerself

skateman commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman commented Oct 10, 2018

himdel commented Oct 10, 2018

skateman Oct 10, 2018

Choose a reason for hiding this comment

AllenBW Oct 10, 2018

Choose a reason for hiding this comment

skateman Oct 10, 2018

Choose a reason for hiding this comment

AllenBW Oct 10, 2018

Choose a reason for hiding this comment

AllenBW commented Oct 10, 2018

AllenBW commented Oct 10, 2018

skateman left a comment

Choose a reason for hiding this comment

himdel left a comment

Choose a reason for hiding this comment

AllenBW commented Oct 12, 2018

simaishi commented Oct 12, 2018

simaishi commented Nov 5, 2018

AllenBW commented Oct 9, 2018 •

edited

Loading