Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with dialogs not loading on reconfigure #1478

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fixed issue with dialogs not loading on reconfigure #1478

merged 1 commit into from
Sep 27, 2018

Conversation

chalettu
Copy link
Contributor

Fix for BZ #1633453
https://bugzilla.redhat.com/show_bug.cgi?id=1633453
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@chalettu
Copy link
Contributor Author

SS Before
failing

SS After
working

@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/ab445dba5677b35d24638dc537f00efdcd91fa8d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@AllenBW AllenBW self-requested a review September 27, 2018 18:44
@AllenBW AllenBW self-assigned this Sep 27, 2018
@AllenBW
Copy link
Member

AllenBW commented Sep 27, 2018

@chalettu does need hammer/yes?

@chalettu
Copy link
Contributor Author

ah, yes. Forgot to add.
@miq-bot add_label hammer/yes

AllenBW
AllenBW approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😋 Awesome catch!

@AllenBW AllenBW merged commit cb7c805 into ManageIQ:master Sep 27, 2018
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@AllenBW @simaishi
Merge pull request #1478 from chalettu/reconfigure_dialogs
f5913d7 
Fixed issue with dialogs not loading on reconfigure

(cherry picked from commit cb7c805)

https://bugzilla.redhat.com/show_bug.cgi?id=1633453
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit f5913d7063089a62f9a0d0b9376969771d460103
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Thu Sep 27 15:16:24 2018 -0400

    Merge pull request #1478 from chalettu/reconfigure_dialogs
    
    Fixed issue with dialogs not loading on reconfigure
    
    (cherry picked from commit cb7c805f4d1808ec755efba563bc958523fe48ac)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1633453

simaishi pushed a commit that referenced this pull request Nov 14, 2018
@AllenBW @simaishi
Merge pull request #1478 from chalettu/reconfigure_dialogs
3efa650 
Fixed issue with dialogs not loading on reconfigure

(cherry picked from commit cb7c805)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635034
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3efa65064bfcfa469c0f6a92020facea6e8adc65
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Thu Sep 27 15:16:24 2018 -0400

    Merge pull request #1478 from chalettu/reconfigure_dialogs
    
    Fixed issue with dialogs not loading on reconfigure
    
    (cherry picked from commit cb7c805f4d1808ec755efba563bc958523fe48ac)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @AllenBW @simaishi