BZ#1589409 - Support for disabling Dashboard

[chalettu]

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1589409

[chalettu]

Screenshot of what it looks like if you don't have access to the Dashboard.

[AllenBW]

closes https://bugzilla.redhat.com/show_bug.cgi?id=1589409

[serenamarie125]

I'm not sure of the RBAC model for the SUI, but I wonder if utilizing something like this might make more sense than only handling a single use case:

• if user access to 1 or more of the nav items, navigate to the first navigation item by default
• if user access to none of the nav items, don't let them in ( i think we previously handled this case )

@chalettu @AllenBW @Loicavenel @ohadlevy thoughts?

[chalettu]

We could set it up to go down the list of menu items and pick the first one that the user has access to. I am not really sure what would be best from what we feel are requirements but let me know what you all think would be the best user experience

[serenamarie125]

I think that makes sense @chalettu but you should def get the 👍from either Ohad or Loic first!

[AllenBW]

Oh oh yeah so if a user can view say, the service catalog, and ONLY the service catalog, thats the page they should be pushed to 😋

[serenamarie125]

yes sir @AllenBW that would be my recommendation

[miq-bot]

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/002cf5c8e057f2a464c50897b494a9104ddddc1c~...9d18ce79cb7051f7ba14a353ef2fc627a7126775 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[chalettu]

Updated the logic to go down the list of pages a user has access to and pick the firsts one they can access and sends them there . So if a person tries to go to a page they do not have access to, they will be redirected to the first menu item they do have access to.

[AllenBW]

So I jumped in with a few users, ones that only had the service catalog role enabled then my orders enabled, the role looking a lil like this...

And for both users, when attempting to login, ended up with this...

[chalettu]

@AllenBW , I tried reproducing the error you are seeing with the role you had pictured above and can't seem to reproduce it. Did you close your browser out and try fresh after saving the role changes? We cache permissions so if you didnt log out first of SUI, sometimes it causes weird things to happen.

[AllenBW]

@chalettu yeah tried it across a number of browsers, bounced the miq instance between changes, same result. Gonna do a box bounce and see if that changes anything 🤷‍♂️

Ooooooo well there we go, testing a bit more, will approve in a bit

[AllenBW]

Looks like this is workin' jusssssstttttttt fineeeeeeeeeeee, furthermore as expected 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 307c96833fe66b7bfccb66ea7ced8c767182b412
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Wed Jun 20 11:27:49 2018 -0400

    Merge pull request #1446 from chalettu/dashboard-permissions
    
    BZ#1589409 - Support for disabling Dashboard
    (cherry picked from commit ae385823137b78b78b1ea6b8abdee77b0b9b2ac4)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1595454