Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1568574 - Fixed issue with custom button details dynamic field refresh #1423

Merged
merged 2 commits into from
Apr 18, 2018
Merged

BZ#1568574 - Fixed issue with custom button details dynamic field refresh #1423

merged 2 commits into from
Apr 18, 2018

Conversation

chalettu
Copy link
Contributor

Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1568574.
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

AllenBW
AllenBW previously approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real quick, does this happen anywhere else in SUI? might be worth a check... 🤔

@AllenBW
Copy link
Member

AllenBW commented Apr 18, 2018

@chalettu looks like travis demands a test update

@chalettu
Copy link
Contributor Author

Yeah. Just saw it and I am updating and retesting it locally. Slashing the / from a few tests

@chrispy1
Copy link

@miq-bot add_label blocker

@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2018

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/e118a37c7f955ab50832b1195dfbf7a82f02ea8f~...9beecbeca7fdc90986398dff8068e6c4e5c59e5d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@AllenBW AllenBW self-assigned this Apr 18, 2018
AllenBW
AllenBW approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M 🌮 💃

@AllenBW AllenBW merged commit 43580fc into ManageIQ:master Apr 18, 2018
simaishi pushed a commit that referenced this pull request Apr 19, 2018
@AllenBW @simaishi
Merge pull request #1423 from chalettu/custom-button-refresh-issue
c482dfe 
BZ#1568574 - Fixed issue with custom button details dynamic field refresh
(cherry picked from commit 43580fc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569551
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c482dfeec80d04c07563c50d2aad3ef327434276
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Wed Apr 18 17:07:18 2018 -0400

    Merge pull request #1423 from chalettu/custom-button-refresh-issue
    
    BZ#1568574 - Fixed issue with custom button details dynamic field refresh
    (cherry picked from commit 43580fc6e2e3126dd2e64d6899b2c162987eaefc)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @AllenBW @chrispy1 @miq-bot @simaishi