-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom-button-menu component styling remains consistent #1395
custom-button-menu component styling remains consistent #1395
Conversation
Checked commits AllenBW/manageiq-ui-service@c681a6d~...ecd6294 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Created https://bugzilla.redhat.com/show_bug.cgi?id=1552201 for this issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed in the UI 👍
…-classes custom-button-menu component styling remains consistent (cherry picked from commit e31fbeb) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553483
Gaprindashvili backport details:
|
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552201
Mild continuation of this work, looks like custom-button-menu componet was a lil borked, didn't have the correct classes applied to the ui-bootstrap tool, this fixes both instances of its use, resource/service details pages.
behavior after this pr
behavior before this pr (wait for it, you wont be disappointed)