Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-button-menu component styling remains consistent #1395

Merged

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Mar 6, 2018

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552201

Mild continuation of this work, looks like custom-button-menu componet was a lil borked, didn't have the correct classes applied to the ui-bootstrap tool, this fixes both instances of its use, resource/service details pages.

behavior after this pr

dropdownmenu

behavior before this pr (wait for it, you wont be disappointed)

dropdownmenufail

@AllenBW
Copy link
Member Author

AllenBW commented Mar 6, 2018

cc @Yadnyawalkya

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2018

Checked commits AllenBW/manageiq-ui-service@c681a6d~...ecd6294 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Yadnyawalkya
Copy link
Member

Created https://bugzilla.redhat.com/show_bug.cgi?id=1552201 for this issue!
Thanks! @AllenBW

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in the UI 👍

@himdel himdel merged commit e31fbeb into ManageIQ:master Mar 8, 2018
@himdel himdel added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 8, 2018
simaishi pushed a commit that referenced this pull request Mar 8, 2018
…-classes

custom-button-menu component styling remains consistent
(cherry picked from commit e31fbeb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553483
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit d511d2ffe1364277b25c03d7d450bcbaf9b048da
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Mar 8 12:59:17 2018 +0000

    Merge pull request #1395 from AllenBW/bug/#1550833-custom-button-menu-classes
    
    custom-button-menu component styling remains consistent
    (cherry picked from commit e31fbeb5e5d06430f712593a52a2297a67baff2c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553483

@AllenBW AllenBW deleted the bug/#1550833-custom-button-menu-classes branch March 12, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants