Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dialog field dynamic refresh #1380

Merged
merged 4 commits into from
Feb 7, 2018
Merged

Fixed dialog field dynamic refresh #1380

merged 4 commits into from
Feb 7, 2018

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Feb 6, 2018 •
edited by simaishi
Loading

This is the second part of ManageIQ/ui-components#246. In order to test out the fix for that PR, we had to fix field dynamic refresh in SUI and also bump ui-components to take in the fix from 246.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539871

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/3b270ec1e0544eaa86e0b548b0179933640bee50~...1db4782c86a863cdd5cdd9f59c7e6ffdfc0a18af with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@AllenBW AllenBW added the blocker label Feb 6, 2018
@AllenBW
Copy link
Member

AllenBW commented Feb 6, 2018

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539871

@AllenBW AllenBW self-assigned this Feb 6, 2018
@AllenBW
Copy link
Member

AllenBW commented Feb 6, 2018

@chalettu any chance we can get a gif of this in action?

@chalettu
Copy link
Contributor Author

chalettu commented Feb 7, 2018

dynamic_refresh

@AllenBW
Copy link
Member

AllenBW commented Feb 7, 2018

@chalettu bz reads:

"Add to shopping cart" button remain disabled after refresh on some dialog fields in SUI.

any chance we can get a gif of this issue resolved?

@chalettu
Copy link
Contributor Author

chalettu commented Feb 7, 2018

Here is a gif of the issue resolved
dynamic field refresh

AllenBW
AllenBW approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

👍 🌮

@AllenBW AllenBW merged commit 6bf479c into ManageIQ:master Feb 7, 2018
simaishi pushed a commit that referenced this pull request Feb 7, 2018
@AllenBW @simaishi
Merge pull request #1380 from chalettu/dynamic_dialog_field_refresh
13910e7 
Fixed dialog field dynamic refresh
(cherry picked from commit 6bf479c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543180
@simaishi
Copy link
Contributor

simaishi commented Feb 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 13910e7528ffbf7c6ada5055db03d936b0c8b5cd
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Wed Feb 7 15:55:23 2018 -0500

    Merge pull request #1380 from chalettu/dynamic_dialog_field_refresh
    
    Fixed dialog field dynamic refresh
    (cherry picked from commit 6bf479c03afb666daa618078ed3f769eb532cb57)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

@himdel himdel Awaiting requested review from himdel

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @AllenBW @simaishi