Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create global variable for version of Patternfly #1379

Merged
merged 2 commits into from
Feb 9, 2018
Merged

Create global variable for version of Patternfly #1379

merged 2 commits into from
Feb 9, 2018

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Feb 6, 2018 •
edited
Loading

This was added in support of ManageIQ/ui-components#249 which deals with different elements based on patternfly version in UI-components repo.
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1539862

@chalettu chalettu changed the title Create global variable for version of Patternfly [WIP] Create global variable for version of Patternfly Feb 6, 2018
@chalettu
Copy link
Contributor Author

chalettu commented Feb 6, 2018

I am leaving this in WIP state until ManageIQ/ui-components#249 gets merged and we can bump the ui-components version in the package.json file.

@chalettu
Copy link
Contributor Author

chalettu commented Feb 6, 2018

Screenshot of what multiselect looks like when this variable is set properly
multiselect

@miq-bot miq-bot added the wip label Feb 6, 2018
@AllenBW AllenBW self-assigned this Feb 6, 2018
@AllenBW AllenBW added the blocker label Feb 6, 2018
@AllenBW
Copy link
Member

AllenBW commented Feb 6, 2018 •
edited
Loading

cc @simaishi

AllenBW
AllenBW previously approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

himdel
himdel previously approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(at least until ui-classic upgrades..)

@himdel
Copy link
Contributor

himdel commented Feb 8, 2018

The ui-components change was released as @manageiq/ui-components@1.0.10, and @manageiq/ui-components@1.1.0.

Feel free to upgrade to either (the difference is just a few recent gaprindashvili/no PRs), but note that only 1.0.* can be backported to gaprindashvili.

@chalettu chalettu dismissed stale reviews from himdel and AllenBW via 306bf85 February 8, 2018 21:28
@chalettu chalettu changed the title [WIP] Create global variable for version of Patternfly Create global variable for version of Patternfly Feb 8, 2018
@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

This pull request is not mergeable. Please rebase and repush.

@chalettu
Added global for patternflyVersion
d5993c9 
This was added in support of ManageIQ/ui-components#249 which deals with different elements based on patternfly version in UI-components repo.
@chalettu
Updated package version for ui-components
f438a0f
@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/d5993c9cb8504bbd73344585603634296a573547~...f438a0faf68eca100cecce559b79b0173b1522c8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot miq-bot removed the wip label Feb 8, 2018
himdel
himdel approved these changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@himdel himdel merged commit 0039298 into ManageIQ:master Feb 9, 2018
@himdel himdel added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 9, 2018
simaishi pushed a commit that referenced this pull request Feb 9, 2018
@himdel @simaishi
Merge pull request #1379 from chalettu/multiselect
7119a75 
Create global variable for version of Patternfly
(cherry picked from commit 0039298)

https://bugzilla.redhat.com/show_bug.cgi?id=1544039
@simaishi
Copy link
Contributor

simaishi commented Feb 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 7119a75a8d23f87b313dffc8285b418fc5b23642
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Feb 9 13:18:13 2018 +0100

    Merge pull request #1379 from chalettu/multiselect
    
    Create global variable for version of Patternfly
    (cherry picked from commit 0039298975fb02ab978fea1061924d1c1f5cc741)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1544039

@AllenBW AllenBW mentioned this pull request Mar 13, 2018
Merged
@himdel himdel mentioned this pull request Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@AllenBW AllenBW AllenBW left review comments

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @AllenBW @himdel @miq-bot @simaishi