Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1527053 - Fixed issue with adding to cart not working #1347

Merged
merged 1 commit into from
Dec 20, 2017
Merged

BZ#1527053 - Fixed issue with adding to cart not working #1347

merged 1 commit into from
Dec 20, 2017

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1527053
I will need to create follow on PR's for Fine

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/a282a8740360dc853d39ca67c1c4164455d06a9c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@chalettu
Copy link
Contributor Author

Screenshot of Fix
add_to_cart_demo

@himdel himdel self-assigned this Dec 20, 2017
@himdel
Copy link
Contributor

himdel commented Dec 20, 2017

LGTM, removes the last use of serviceTemplate.

@himdel himdel merged commit eebcdc2 into ManageIQ:master Dec 20, 2017
@himdel himdel added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 20, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 80120059c292807addbbdfd2526103ead4be7393
Author: Martin Hradil <himdel@seznam.cz>
Date:   Wed Dec 20 18:02:25 2017 +0100

    Merge pull request #1347 from chalettu/add_to_cart_fix
    
    BZ#1527053 - Fixed issue with adding to cart not working
    (cherry picked from commit eebcdc254000d68a75985ed8fa8b2f88510b2a0d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530798

simaishi pushed a commit that referenced this pull request Jan 3, 2018
BZ#1527053 - Fixed issue with adding to cart not working
(cherry picked from commit eebcdc2)

https://bugzilla.redhat.com/show_bug.cgi?id=1530798
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2018

Backported to Fine via #1348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants